Remove READ_PHONE_STATE permission

[askaaron]

I understand, that Poweramp needs to know when a phone call occurs so it can lower its volume or stop play back.

 

Unfortunately READ_PHONE_STATE not only allows to get notifications for calls - but also the calling phone number, IMEI etc.

 

It is also possible to use OnAudioFocusChangeListener() without READ_PHONE_STATE permission in the manifest - also see:

 

http://developer.android.com/reference/android/media/AudioManager.OnAudioFocusChangeListener.html

 

And one App which uses this method to stop play back when a phone call occurs (TTS+ Plugin for FBReader):

 

http://hyperionics.com/forum2/tm.aspx?m=9484&mpage=1

 

Even though I don't assume that Poweramp behaves bad - but removing this permission and changing the code to use OnAudioFocusChangeListener() instead of PhoneStateListener() would improve the trust to Poweramp that it will not misuse any confidential data.

 

[sekhar13515]

Hi admin,

Actually, I am not so familiar about the above matter.

But when listening music, and when we get incoming call, the volume is a lot loud and not bearable to hear, because as the phone is generally in Normal mode.

So when connecting headset to Poweramp, decrease the phone incoming call volume as default to 20%.

This would be nice feature if you implement..

[maxmp]

Correct, the above mentioned method (audio focus API) doesn't require telephony subsystem permissions. But:

1. Poweramp works on Androids starting from 2.1. There are no audio focus API

2. Poweramp reacts on phone call differently - it doesn't unload it service to allow resume after the call.

 

The next major release drops support for Androids 2.1/2.2 so #1 is not an issue. Poweramp itself doesn't do anything with call data beyond pausing/resuming on call/hang, but as next Poweramp will be able to load in-process plugins, the permission set will be reviewed and restricted further. #2 is a minor one.

 

Thanks!

[Petrovsky]

I'll purchase Poweramp when it doesn't need personal data in order to play my music.  Thanks for explaining the technical reasons why it does what it does.

[andrewilley]

See Max's comment above your post. Not sure whether permissions are (or will be) any different in v3 though.

Andre