Jump to content

Opus ReplayGain tags ignored


LuK1337

Recommended Posts

56 minutes ago, LuK1337 said:

After editing tags with ExFalso, Poweramp fails to parse RG tags. I attached both files along with screenshots showing the issue.

So what changes were made by ExFalso? Seems this is the program that made a change that affected Poweramp. Does any other ReplayGain capable player have a similar issue?

Link to comment
Share on other sites

48 minutes ago, MotleyG said:

So what changes were made by ExFalso? Seems this is the program that made a change that affected Poweramp. Does any other ReplayGain capable player have a similar issue?

According to ffprobe the tags are just...in different order, and I have no idea how other players deal with that.

EDIT 1: ...Oh, they are also lowercase, maybe that's why.

EDIT 2: Yeah, when I opened libpowerampcore.so in IDA, I noticed that it does `av_dict_get(a1, "R128_TRACK_GAIN", NULL, AV_DICT_MATCH_CASE | AV_DICT_IGNORE_SUFFIX);`, so I assume that if `AV_DICT_MATCH_CASE` was dropped it'd work properly.

EDIT 3: I patched libpowerampcore.so to pass just `AV_DICT_IGNORE_SUFFIX` and that solves the issue ^.^

Edited by LuK1337
Link to comment
Share on other sites

1 hour ago, LuK1337 said:

EDIT 1: ...Oh, they are also lowercase, maybe that's why.

Yes, I was just checking the files and noticed the change in case.

Good:
image.png#

Bad:
 image.png

We've seen that causing issues before, with AlbumGain in particular being case sensitive. As you say, I'm sure it can be coded around in Poweramp to make these tags case insensitive too, but for now just stick to UPPER case.

Andre

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...